Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add a testing valuer which always returns an error #724

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore: add a testing valuer which always returns an error #724

merged 1 commit into from
Jul 28, 2023

Conversation

jjeffcaii
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (a6636b7) 36.51% compared to head (34ed258) 36.51%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   36.51%   36.51%   -0.01%     
==========================================
  Files         247      247              
  Lines       26159    26161       +2     
==========================================
  Hits         9552     9552              
- Misses      15535    15537       +2     
  Partials     1072     1072
Files Changed Coverage Δ
pkg/runtime/optimize/dml/select.go 0.26% <ø> (ø)
pkg/runtime/plan/dml/local_select.go 0.00% <0.00%> (ø)
pkg/runtime/plan/dml/local_sequence.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.7% 11.7% Duplication

@dongzl dongzl added this to the 0.2.0 milestone Jul 28, 2023
@dongzl dongzl added the enhancement New feature or request label Jul 28, 2023
@AlexStocks AlexStocks merged commit 69019ed into arana-db:master Jul 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongzl dongzl dongzl approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@Mulavar Mulavar Mulavar approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jjeffcaii @codecov-commenter @dongzl @AlexStocks @Mulavar